Re: [PATCH] ASoC: ak4458: remove "reset-gpios" property handler

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Jul 03, 2024 at 08:26:15PM +0800, Shengjiu Wang wrote:
> commit c721f189e89c0 ("reset: Instantiate reset GPIO controller for
> shared reset-gpios") check if there is no "resets" property
> will fallback to "reset-gpios".
> 
> So don't need to handle "reset-gpios" separately in the driver,
> the "reset-gpios" handler is duplicated with "resets" control handler,
> remove it.

...

> -	if (ak4458->reset_gpiod) {
> -		gpiod_set_value_cansleep(ak4458->reset_gpiod, active);
> -		usleep_range(1000, 2000);
> -	} else if (!IS_ERR_OR_NULL(ak4458->reset)) {
> +	if (!IS_ERR_OR_NULL(ak4458->reset)) {

_OR_NULL is redundant.

>  		if (active)
>  			reset_control_assert(ak4458->reset);
>  		else

-- 
With Best Regards,
Andy Shevchenko