Re: [PATCH 1/3] ASoC: dt-bindings: qcom,sm8250: Add generic QCM6490 sound card

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 09/08/2024 10:33, Luca Weiss wrote:
> Document the bindings for the Qualcomm QCM6490 sound card.
> 
> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> index c9076dcd44c1..0a31be6d917f 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> @@ -31,6 +31,7 @@ properties:
>            - qcom,apq8096-sndcard
>            - qcom,msm8916-qdsp6-sndcard
>            - qcom,qcm6490-idp-sndcard
> +          - qcom,qcm6490-sndcard

I think it would be better to make it a board-compatible and also
followed by qcom,qcm6490-idp-sndcard fallback, thus no need for driver
changes.

Best regards,
Krzysztof