Re: [PATCH] ALSA: caiaq: Fix unused variable warning

[Jerome Brunet <jbrunet@xxxxxxxxxxxx>]

On Fri 09 Aug 2024 at 09:42, Takashi Iwai <tiwai@xxxxxxx> wrote:

> The recent cleanup of caiaq driver forgot to remove the unused loop
> variable:
> sound/usb/caiaq/audio.c: In function 'snd_usb_caiaq_pcm_prepare':
> sound/usb/caiaq/audio.c:179:41: error: unused variable 'i' [-Werror=unused-variable]
>
> Fixes: e95b9f7f2ee0 ("ALSA: snd-usb-caiaq: use snd_pcm_rate_to_rate_bit")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/20240809112252.5af8025f@xxxxxxxxxxxxxxxx
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Urgh, sorry about that. Thanks for taking care of it.

> ---
>  sound/usb/caiaq/audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c
> index e62a4ea1d19c..772c0ecb7077 100644
> --- a/sound/usb/caiaq/audio.c
> +++ b/sound/usb/caiaq/audio.c
> @@ -176,7 +176,7 @@ static int snd_usb_caiaq_pcm_hw_free(struct snd_pcm_substream *sub)
>  
>  static int snd_usb_caiaq_pcm_prepare(struct snd_pcm_substream *substream)
>  {
> -	int bytes_per_sample, bpp, ret, i;
> +	int bytes_per_sample, bpp, ret;
>  	int index = substream->number;
>  	struct snd_usb_caiaqdev *cdev = snd_pcm_substream_chip(substream);
>  	struct snd_pcm_runtime *runtime = substream->runtime;

-- 
Jerome