Re: [PATCH v3 3/4] ALSA: timer: Introduce virtual userspace-driven timers

[Jaroslav Kysela <perex@xxxxxxxx>]

On 06. 08. 24 14:52, Ivan Orlov wrote:
> Implement two ioctl calls in order to support virtual userspace-driven
> ALSA timers.

...

> +struct snd_utimer_info {
> +	/*
> +	 * To pretend being a normal timer, we need to know the frame rate and
> +	 * the period size in frames.
> +	 */
> +	__u64 frame_rate;
> +	__u64 period_size;

There should be just one timer resolution in ns member (like in struct 
snd_timer_ginfo - not frame/period members here - it's too specific). The 
resolution can be calculated in the user space from the rate and period size.

Also naming - the timer API uses snd_timer prefix for structures, thus 
snd_timer_uinfo should be more appropriate.

					Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.