On 09/07/2024 19:28, Igor Prusov wrote:
> Add dt-bindings for NeoFidelity NTP8918 Amplifier
>
> Signed-off-by: Igor Prusov <ivprusov@xxxxxxxxxxxxxxxxx>
> ---
> .../bindings/sound/neofidelity,ntp8918.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/neofidelity,ntp8918.yaml
>
This looks like not tested, so limited review follows.
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> +> +description: |
Do not need '|' unless you need to preserve formatting.
> + The NTP8918 is a single chip full digital audio amplifier
> + including power stage for stereo amplifier system.
> + The NTP8918 is integrated with versatile digital audio signal
> + processing functions, high-performance, high-fidelity fully
> + digital PWM modulator and two high-power full-bridge MOSFET
> + power stages.
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - neofidelity,ntp8918
> +
> + reg:
> + maxItems: 1
> + enum:
> + - 0x2a
> + - 0x2b
> + - 0x2c
> + - 0x2d
> + description: |
> + I2C address of the device.
Drop description, redundant.
> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO used to control the state of the device.
Drop description, redundant.
> +
> + '#sound-dai-cells':
> + enum: [0]
That's a const
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + ntp8918@54 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
[Index of Archives]
[Pulseaudio]
[Linux Audio Users]
[ALSA Devel]
[Fedora Desktop]
[Fedora SELinux]
[Big List of Linux Books]
[Yosemite News]
[KDE Users]