Re: [PATCH 2/3] Removed extra asterisks from comment beginnings, and removed unnecessary comment end

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 07/07/2024 06:14, Gold Side wrote:
> From 33dc0aa3973913f310840cc8f7d5d599d573c297 Mon Sep 17 00:00:00 2001
> From: Steven Davis <goldside000@xxxxxxxxxxx>
> Date: Tue, 2 Jul 2024 23:43:15 -0400
> Subject: [PATCH 2/3] Removed unnecessary comment end
> 
> It still works the same without that comment end, so why is it in there?

Because license-rules asks for it. Why do you change only one file? Look
how this is done in other files. This should make you ask questions why
doing things differently.

> Signed-off-by: Steven Davis <goldside000@xxxxxxxxxxx>

Please use git to create commits, not hand-craft them. Missing blank
line before tag.

Entire patch does not look like proper patch, but some weirdly generated
mbox file. :/ Use git format-patch or b4.

> ---
>  include/memory/renesas-rpc-if.h | 2 +-

Best regards,
Krzysztof





[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux