Re: [PATCH 1/3] Removed extra asterisks from comment beginnings, and removed unnecessary comment end

[Randy Dunlap <rdunlap@xxxxxxxxxxxxx>]

On 7/6/24 9:14 PM, Gold Side wrote:
> From 3574f0514207f9610a69d82d3dd0d018d6dce5dd Mon Sep 17 00:00:00 2001
> From: Steven Davis <goldside000@xxxxxxxxxxx>
> Date: Tue, 2 Jul 2024 22:57:24 -0400
> Subject: [PATCH 1/3] Removed extra asterisk from comment beginning
> 
> It saves a byte. I'd imagine bytes are valuable in a project like this.

Don't think so.

> PS: Please forgive my previous patch email, I didn't know the guidelines well.
> Signed-off-by: Steven Davis <goldside000@xxxxxxxxxxx
> ---
>  kernel/module/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index d18a94b973e102..25e456f4381c71 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -450,7 +450,7 @@ bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr)
>       return false;
>  }
>  
> -/**
> +/*
>   * is_module_percpu_address() - test whether address is from module static percpu
>   * @addr: address to test
>   *

"/**" means "begin kernel-doc comment." Documentation is important.

Also, why drop one asterisk for this function and not for the other 5 functions in this source
file that use "/**" to begin a kernel-doc comment block?


-- 
~Randy