Re: [PATCH RESEND v11 0/5] Add support for CS40L50

[James Ogletree <James.Ogletree@xxxxxxxxxx>]

> On Jun 28, 2024, at 3:06 AM, Lee Jones <lee@xxxxxxxxxx> wrote:
> 
> On Thu, 27 Jun 2024, James Ogletree wrote:
> 
>> 
>>> On Jun 27, 2024, at 2:12 AM, Lee Jones <lee@xxxxxxxxxx> wrote:
>>> 
>>> On Wed, 26 Jun 2024, James Ogletree wrote:
>>> 
>>>> 
>>>>> On Jun 20, 2024, at 11:59 AM, Lee Jones <lee@xxxxxxxxxx> wrote:
>>>>> 
>>>>> On Thu, 20 Jun 2024, James Ogletree wrote:
>>>>> 
>>>>>> Changes in v11:
>>>>>> - Constified function parameters in ASOC driver
>>>>>> - Removed an unneeded #include
>>>>>> - Changed number of max FF effects = 1
>>>>>> - Minor refactoring in Input driver
>>>>>> - Reworded comment in MFD driver
>>>>>> 
>>>>>> Changes in v10:
>>>>>> - Minor refactoring and logical improvements all around
>>>>>> - Renamed and added supplies
>>>>>> 
>>>>>> Changes in v9:
>>>>>> - Fixed empty struct by utilizing cs_dsp's post_run callback
>>>>>> - Style fixes in MFD driver
>>>>>> 
>>>>>> Changes in v8:
>>>>>> - set_sysclk() -> set_bclk_ratio()
>>>>>> - Added ID table to codec driver
>>>>>> - Style improvements
>>>>>> - Fixed ordering of new write sequence operations
>>>>>> 
>>>>>> Changes in v7:
>>>>>> - Fixed sparse warning
>>>>>> - Moved write sequences to private data structure
>>>>>> - Logical and style improvements in write sequence interface
>>>>>> 
>>>>>> Changes in v6:
>>>>>> - Updated write sequencer interface to be control-name based
>>>>>> - Fixed a race condition and non-handling of repeats in playback callback
>>>>>> - Stylistic and logical improvements all around
>>>>>> 
>>>>>> Changes in v5:
>>>>>> - Added a codec sub-device to support I2S streaming
>>>>>> - Moved write sequencer code from cirrus_haptics to cs_dsp
>>>>>> - Reverted cirrus_haptics library; future Cirrus input
>>>>>> drivers will export and utilize cs40l50_vibra functions
>>>>>> - Added more comments
>>>>>> - Many small stylistic and logical improvements
>>>>>> 
>>>>>> Changes in v4:
>>>>>> - Moved from Input to MFD
>>>>>> - Moved common Cirrus haptic functions to a library
>>>>>> - Incorporated runtime PM framework
>>>>>> - Many style improvements
>>>>>> 
>>>>>> Changes in v3:
>>>>>> - YAML formatting corrections
>>>>>> - Fixed typo in MAINTAINERS
>>>>>> - Used generic node name "haptic-driver"
>>>>>> - Fixed probe error code paths
>>>>>> - Switched to "sizeof(*)"
>>>>>> - Removed tree reference in MAINTAINERS
>>>>>> 
>>>>>> Changes in v2:
>>>>>> - Fixed checkpatch warnings
>>>>>> 
>>>>>> James Ogletree (5):
>>>>>> firmware: cs_dsp: Add write sequence interface
>>>>>> dt-bindings: input: cirrus,cs40l50: Add initial DT binding
>>>>>> mfd: cs40l50: Add support for CS40L50 core driver
>>>>>> Input: cs40l50 - Add support for the CS40L50 haptic driver
>>>>>> ASoC: cs40l50: Support I2S streaming to CS40L50
>>>>>> 
>>>>>> .../bindings/input/cirrus,cs40l50.yaml        |  68 +++
>>>>>> MAINTAINERS                                   |  12 +
>>>>>> drivers/firmware/cirrus/cs_dsp.c              | 278 +++++++++
>>>>>> drivers/input/misc/Kconfig                    |  10 +
>>>>>> drivers/input/misc/Makefile                   |   1 +
>>>>>> drivers/input/misc/cs40l50-vibra.c            | 555 +++++++++++++++++
>>>>>> drivers/mfd/Kconfig                           |  30 +
>>>>>> drivers/mfd/Makefile                          |   4 +
>>>>>> drivers/mfd/cs40l50-core.c                    | 570 ++++++++++++++++++
>>>>>> drivers/mfd/cs40l50-i2c.c                     |  68 +++
>>>>>> drivers/mfd/cs40l50-spi.c                     |  68 +++
>>>>>> include/linux/firmware/cirrus/cs_dsp.h        |  27 +
>>>>>> include/linux/mfd/cs40l50.h                   | 137 +++++
>>>>>> sound/soc/codecs/Kconfig                      |  11 +
>>>>>> sound/soc/codecs/Makefile                     |   2 +
>>>>>> sound/soc/codecs/cs40l50-codec.c              | 307 ++++++++++
>>>>>> 16 files changed, 2148 insertions(+)
>>>>>> create mode 100644 Documentation/devicetree/bindings/input/cirrus,cs40l50.yaml
>>>>>> create mode 100644 drivers/input/misc/cs40l50-vibra.c
>>>>>> create mode 100644 drivers/mfd/cs40l50-core.c
>>>>>> create mode 100644 drivers/mfd/cs40l50-i2c.c
>>>>>> create mode 100644 drivers/mfd/cs40l50-spi.c
>>>>>> create mode 100644 include/linux/mfd/cs40l50.h
>>>>>> create mode 100644 sound/soc/codecs/cs40l50-codec.c
>>>>> 
>>>>> Still needs Acks - ping me when you have them.
>>>>> 
>>>>> -- 
>>>>> Lee Jones [李琼斯]
>>>> 
>>>> Hi Lee,
>>>> 
>>>> You can take this series now.
>>> 
>>> sound/soc?
>>> 
>>> -- 
>>> Lee Jones [李琼斯]
>> 
>> Mark has Acked the original v11 series here:
>> https://urldefense.com/v3/__https://lore.kernel.org/all/a85e09d6-d8eb-4c60-ae83-b4dbf875a926@xxxxxxxxxxxxx/__;!!DQ3KfwI!0a407iFiKYCsNXJTLf65046j5eBK-mijVgGMYsX8Rg8dCaxttzQAKBI976mPk_AxuVs7n1zqpQmpy7o$
> 
> Ah, you just forgot to add it to the RESEND?
> 
> Okay, leave it with me then.
> 
> -- 
> Lee Jones [李琼斯]

Actually it was Acked on the original v11 series after the RESEND had been sent
out. If you like, I can resend with all the collected tags.

Best,
James