Re: [PATCH v2 3/3] arm64: dts: imx8mp-evk: Add audio XCVR sound card

[Shengjiu Wang <shengjiu.wang@xxxxxxxxx>]

On Fri, Jun 28, 2024 at 9:13 AM Peng Fan <peng.fan@xxxxxxx> wrote:
>
> > Subject: [PATCH v2 3/3] arm64: dts: imx8mp-evk: Add audio XCVR
> > sound card
> >
> > Add audio XCVR sound card, which supports SPDIF TX & RX, eARC RX,
> > ARC RX functions.
> >
> > HDMI_HPD is shared with the HDMI module so use pinctrl_hog.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 27
> > ++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > index c2c708c492c0..a64e8a6c830d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > @@ -209,6 +209,19 @@ cpu {
> >               };
> >       };
> >
> > +     sound-xcvr {
> > +             compatible = "fsl,imx-audio-card";
> > +             model = "imx-audio-xcvr";
> > +
> > +             pri-dai-link {
> > +                     link-name = "XCVR PCM";
> > +
> > +                     cpu {
> > +                             sound-dai = <&xcvr>;
> > +                     };
> > +             };
> > +     };
> > +
> >       reserved-memory {
> >               #address-cells = <2>;
> >               #size-cells = <2>;
> > @@ -748,7 +761,15 @@ &wdog1 {
> >       status = "okay";
> >  };
> >
> > +&xcvr {
> > +     #sound-dai-cells = <0>;
> > +     status = "okay";
> > +};
> > +
> >  &iomuxc {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_hog>;
>
> Could this be put under xcvr node?

The issue is that this pin is shared with HDMI video function.
So I think it is better to put it in iomuxc.

Best regards
Shengjiu Wang
>
> Regards,
> Peng.
> > +
> >       pinctrl_audio_pwr_reg: audiopwrreggrp {
> >               fsl,pins = <
> >                       MX8MP_IOMUXC_SAI3_RXC__GPIO4_IO29
> >               0xd6
> > @@ -838,6 +859,12 @@
> > MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16 0x140
> >               >;
> >       };
> >
> > +     pinctrl_hog: hoggrp {
> > +             fsl,pins = <
> > +
> >       MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD
> >       0x40000010
> > +             >;
> > +     };
> > +
> >       pinctrl_i2c1: i2c1grp {
> >               fsl,pins = <
> >                       MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL
> >       0x400001c2
> > --
> > 2.34.1
> >
>