Re: [PATCH 2/6] ASoC: codecs: wsa883x: parse port-mapping information

[Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>]

On 27/06/2024 14:36, Dmitry Baryshkov wrote:
> On Thu, Jun 27, 2024 at 12:55:18PM GMT, Srinivas Kandagatla wrote:
> > Add support to parse static master port map information from device tree.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   sound/soc/codecs/wsa883x.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c
> > index a2e86ef7d18f..43156d39480f 100644
> > --- a/sound/soc/codecs/wsa883x.c
> > +++ b/sound/soc/codecs/wsa883x.c
> > @@ -1399,6 +1399,14 @@ static int wsa883x_probe(struct sdw_slave *pdev,
> >   	wsa883x->sconfig.direction = SDW_DATA_DIR_RX;
> >   	wsa883x->sconfig.type = SDW_STREAM_PDM;
> >   
> > +	/**
> > +	 * Port map index starts with 0, however the data port for this codec
> > +	 * are from index 1
> > +	 */
> > +	if (of_property_read_u32_array(dev->of_node, "qcom,port-mapping", &pdev->m_port_map[1],
> > +					WSA883X_MAX_SWR_PORTS))
> > +		dev_info(dev, "Static Port mapping not specified\n");
>
> dev_info looks strange. It should be either dev_warn or dev_dbg.

dev_dbg should be good in this case!

--srini
> > +
> >   	pdev->prop.sink_ports = GENMASK(WSA883X_MAX_SWR_PORTS, 0);
> >   	pdev->prop.simple_clk_stop_capable = true;
> >   	pdev->prop.sink_dpn_prop = wsa_sink_dpn_prop;
> >
> > --
> > 2.25.1