Re: [PATCH 2/4] ASoC: Intel: maxim-common: add max_98373_get_tx_mask function

[Mark Brown <broonie@xxxxxxxxxx>]

On Mon, Jun 24, 2024 at 05:26:37PM +0200, Pierre-Louis Bossart wrote:
> On 6/24/24 14:37, Mark Brown wrote:
> > On Mon, Jun 24, 2024 at 02:11:17PM +0200, Pierre-Louis Bossart wrote:
> >> From: Brent Lu <brent.lu@xxxxxxxxx>

> >> Add a helper function max_98373_get_tx_mask() to get tx mask from
> >> max98373 ACPI device properties at runtime.

> > Similarly here.

> I may have misunderstood Brent's patch but this isn't a fix really, more
> a cleanup to use ACPI when possible, with a fallback to the existing
> hard-coded setup if ACPI properties are not found.

> I don't think it's a real 'fix' impacting users, in the linux-stable
> sense, nor that this needs to be back-ported with case.

> Brent, please chime in if I am mistaken?

Yes, in this case the issue is that everything else looked like it
should be a fix but this isn't.

Attachment: signature.asc
Description: PGP signature