Re: [PATCH] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx

[Takashi Iwai <tiwai@xxxxxxx>]

On Mon, 24 Jun 2024 10:55:04 +0200,
Aivaz wrote:
> 
> 
> I'm sorry, but I didn't look at my vendor and device id correctly. Here's the
> right one:

Please resubmit as v2 patch.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f4454abadc8d..51225c5770ea 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] =
> {
>         SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
>         SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
>         SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> +       SND_PCI_QUIRK(0x103с, 0x87d3, "HP Laptop 15-gw0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>         SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>         SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
>         SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
> ALC236_FIXUP_HP_GPIO_LED),
> 
> On Sun, 23 Jun 2024 at 16:25, Aivaz Latypov <reichaivaz@xxxxxxxxx> wrote:
> 
>     This HP Laptop uses ALC236 codec with COEF 0x07 controlling
>     the mute LED. Enable existing quirk for this device.
>    
>     Signed-off-by: Aivaz Latypov <reichaivaz@xxxxxxxxx>
>     ---
>      sound/pci/hda/patch_realtek.c | 1 +
>      1 file changed, 1 insertion(+)
>    
>     diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>     index f4454abadc8d..51225c5770ea 100644
>     --- a/sound/pci/hda/patch_realtek.c
>     +++ b/sound/pci/hda/patch_realtek.c
>     @@ -10067,6 +10067,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl
>     [] = {
>             SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15",
>     ALC285_FIXUP_HP_MUTE_LED),
>             SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15",
>     ALC285_FIXUP_HP_MUTE_LED),
>             SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15",
>     ALC285_FIXUP_HP_MUTE_LED),
>     +       SND_PCI_QUIRK(0x10ec, 0x0236, "HP Laptop 15-gw0xxx",
>     ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>             SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx",
>     ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>             SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
>             SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
>     ALC236_FIXUP_HP_GPIO_LED),
>     --
>     2.45.2
>