Re: [PATCH v2 2/2] ASoC: codecs:lpass-wsa-macro: Fix logic of enabling vi channels

[Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>]

On 20/06/2024 21:28, Dmitry Baryshkov wrote:
> On Wed, Jun 19, 2024 at 02:42:01PM GMT, Srinivas Kandagatla wrote:
> > Existing code only configures one of WSA_MACRO_TX0 or WSA_MACRO_TX1
> > paths eventhough we enable both of them. Fix this bug by adding proper
> > checks and rearranging some of the common code to able to allow setting
> > both TX0 and TX1 paths
>
> Same question. What is the observed issue? Corrupted audio? Cracking?
> Under/overruns?

two Issues with existing code which are addressed by these two patches.

-> only one channels gets enabled on VI feedback path instead of 2 
channels. resulting in 1 channel recording instead of 2.
-> rate is not set correctly for the VI record path.


--srini


> > Fixes: 2c4066e5d428 ("ASoC: codecs: lpass-wsa-macro: add dapm widgets and route")
> > Co-developed-by: Manikantan R <quic_manrav@xxxxxxxxxxx>
> > Signed-off-by: Manikantan R <quic_manrav@xxxxxxxxxxx>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   sound/soc/codecs/lpass-wsa-macro.c | 112 ++++++++++++++++++++++---------------
> >   1 file changed, 68 insertions(+), 44 deletions(-)