Re: [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver

[Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>]

Le 19/06/2024 à 13:02, Mohammad Rafi Shaik a écrit :
> On 6/17/2024 5:25 PM, Mark Brown wrote:
> > On Sun, Jun 16, 2024 at 04:54:58PM +0200, Christophe JAILLET wrote:
> > > Le 11/06/2024 à 09:45, Mohammad Rafi Shaik a écrit :
> >
> > > > +static void wcd937x_soc_codec_remove(struct snd_soc_component 
> > > > *component)
> > > > +{
> > > > +    struct wcd937x_priv *wcd937x = 
> > > > snd_soc_component_get_drvdata(component);
> > > > +
> > > > +    wcd937x_mbhc_deinit(component);
> > > > +    free_irq(wcd937x->aux_pdm_wd_int, wcd937x);
> > > > +    free_irq(wcd937x->hphl_pdm_wd_int, wcd937x);
> > > > +    free_irq(wcd937x->hphr_pdm_wd_int, wcd937x);
> >
> > > These irq have been requested wth devm_request_threaded_irq(), so either
> > > this free_irq should be removed, or devm_free_irq() should be used if 
> > > the
> > > order is important.
> >
> > Yes, this should be fixed.
>
> okay, will check and provide the fix.
>
>
> Thanks & Regards,
> Rafi.

Hi,

just to make things explicit, in case you missed it: I sent 2 comments 
in 2 different mails.

  - the one above: 
https://lore.kernel.org/all/2b92c0f9-2595-4b73-8015-1abb825a61a1@xxxxxxxxxx/

  - and another one: 
https://lore.kernel.org/all/834d31cc-f4bc-4db7-a25b-f9869e550eb6@xxxxxxxxxx/

If you give it a look, could you please also check the 2nd one?

CJ