Re: [PATCH v3 2/2] ASoC: cs530x: Support for cs530x ADCs

[Mark Brown <broonie@xxxxxxxxxx>]

On Tue, Jun 18, 2024 at 03:43:59PM +0100, Richard Fitzgerald wrote:
> On 18/06/2024 15:25, Mark Brown wrote:

> > Marking the register as read only should DTRT there, if not then that's
> > a regmap bug which should be fixed.

> True but now we're adding extra callbacks and complexity just to
> avoid marking a register volatile for some reason. The driver doesn't
> need it to be cached, so why bother?

Well, moving the volatile callback to be a readable callback.  If
nothing else it avoids anyone reading the code and having to wonder why
the ID registers are volatile.

Attachment: signature.asc
Description: PGP signature