Re: [PATCH] dt-bindings: wlf,wm8782: Convert to dtschema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Jun 11, 2024 at 06:14:00PM +0530, Animesh Agarwal wrote:
> Convert the WM8782 audio codec bindings to DT schema.

Missing "ASoC" on the subject. Mark may not see it.

> Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx>
> Cc: Daniel Baluta <daniel.baluta@xxxxxxx>
> ---
>  .../devicetree/bindings/sound/wlf,wm8782.yaml | 47 +++++++++++++++++++
>  .../devicetree/bindings/sound/wm8782.txt      | 24 ----------
>  2 files changed, 47 insertions(+), 24 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8782.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/wm8782.txt

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>


This is yet another binding with no in tree DTS user. That's fine, but 
not what I would prioritize converting. There are several ways I would 
prioritize what to work on.

- There's a list maintained in CI of number of occurrences of
undocumented (by schema) compatibles[1]. Start at the top (most 
occurrences).
- Pick a platform (or family of platform) and get the warnings down to
0 or close. There's a grouping of warnings and undocumented
compatibles by platform family at the same link. Pick something that's 
widely used like RPi or RK3399.
- Prioritize newer platforms over older (arm64 rather than
arm32(though there's still new arm32 stuff)).
- Fix warnings treewide from common schemas (i.e. from dtschema).
That's not conversions, but related.

Happy to discuss further what you plan to do. All the DT maintainers are 
on IRC (#devicetree on Libera).

Rob

[1] https://gitlab.com/robherring/linux-dt/-/jobs/6918723853




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux