Re: Re: [PATCH v2 1/2] ALSA: dmaengine: Synchronize dma channel in prepare()

[Jai Luthra <j-luthra@xxxxxx>]

Hi Lars, Mark,

On Jun 11, 2024 at 11:39:12 +0100, Mark Brown wrote:
> On Mon, Jun 10, 2024 at 05:45:52PM -0700, Lars-Peter Clausen wrote:
> > On 6/10/24 03:56, Jai Luthra wrote:
> 
> > > Sometimes the stream may be stopped due to XRUN events, in which case
> > > the userspace can call snd_pcm_drop() and snd_pcm_prepare() to stop and
> > > start the stream again.
> 
> > > In these cases, we must wait for the DMA channel to synchronize before
> > > marking the stream as prepared for playback, as the DMA channel gets
> > > stopped by snd_pcm_drop() without any synchronization.
> 
> > We should really implement the sync_stop() PCM callback and let the ALSA
> > core let care of the sync.
> 
> Good point, that's a better idea.

Thanks for the suggestion, sending a v3 with the change.

Peter,
I've kept your R-by intact as it is a minor change.


-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

Attachment: signature.asc
Description: PGP signature