Re: [PATCH 1/2] ASoC: dt-bindings: tlv320adc3xxx: Add MICBIAS-as-GPO properties

[Rob Herring <robh@xxxxxxxxxx>]

yOn Wed, May 29, 2024 at 06:33:44PM +0200, Ricard Wanderlof wrote:
> Add properties for configuring the MICBIAS pins as general purpose
> outputs, with some limitations: The voltage on the pin when activated
> may be set using another property to 2.0 V, 2.5 V or AVDD.
> When deactivated the pin will float.
> 
> Signed-off-by: Ricard Wanderlof <ricard.wanderlof@xxxxxxxx>
> ---
>  .../devicetree/bindings/sound/ti,tlv320adc3xxx.yaml  | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml
> index ede14ca2c07a..4172aced1386 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tlv320adc3xxx.yaml
> @@ -82,6 +82,26 @@ properties:
>        Note that there is currently no support for reading the GPIO pins as
>        inputs.
>  
> +  ti,micbias1-gpo:
> +    type: boolean
> +    description: |
> +      When set, the MICBIAS1 pin may be controlled via the GPIO framework,
> +      as pin number 3 on the device.
> +
> +      In this mode, when the pin is activated, it will be set to the voltage
> +      specified by the ti,micbias1-vg property. When deactivated, the pin will
> +      float.
> +
> +  ti,micbias2-gpo:
> +    type: boolean
> +    description: |
> +      When set, the MICBIAS2 pin may be controlled via the GPIO framework,
> +      as pin number 4 on the device.
> +
> +      In this mode, when the pin is activated, it will be set to the voltage
> +      specified by the ti,micbias1-vg property. When deactivated, the pin will
> +      float.

Typo and sounds like a dependency between properties:

dependencies:
  ti,micbias2-gpio: [ti,micbias2-vg]

> +
>    ti,micbias1-vg:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum:
> 
> -- 
> 2.30.2
>