From: "Mark Brown" <broonie@xxxxxxxxxx> Sent: Friday, 17 May, 2024 13:06:03 > On Fri, May 17, 2024 at 05:05:38AM -0400, Elinor Montmasson wrote: > >> This new compatible is intended to be used when there is no codec >> device/driver. There is technically no codec device/driver for which >> the clock input can be set. > > This is obviously not true, there clearly is a driver. > >> Is it a bad idea to allow setting the cpu sysclk direction only ? >> Should the compatible be limited to use-cases where the cpu sysclk >> direction cannot be set by the machine driver ? > > When I said "this should use the clock bindings" I meant that we should > use the clock bindings for configuration here. As far I as know, it's not possible to set the direction with the clock bindings, but maybe there is and I missed something ?
- Follow-Ups:
- References:
- [PATCHv4 0/9] ASoC: fsl-asoc-card: compatibility integration of a generic codec use case for use with S/PDIF controller
- From: Elinor Montmasson
- [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"
- From: Elinor Montmasson
- Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"
- From: Mark Brown
- Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"
- From: Elinor Montmasson
- Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"
- From: Mark Brown
- [PATCHv4 0/9] ASoC: fsl-asoc-card: compatibility integration of a generic codec use case for use with S/PDIF controller
- Prev by Date: Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec
- Next by Date: Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec
- Previous by thread: Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"
- Next by thread: Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"
- Index(es):