Re: [RFC PATCH] ALSA: compress_offload: introduce passthrough operation mode

[Takashi Iwai <tiwai@xxxxxxx>]

On Mon, 27 May 2024 12:13:30 +0200,
Amadeusz Sławiński wrote:
> 
> > +static int snd_compr_task_status(struct snd_compr_stream *stream,
> > +					struct snd_compr_task_status *status)
> > +{
> > +	struct snd_compr_task_runtime *task;
> > +
> > +	task = snd_compr_find_task(stream, status->seqno);
> > +	if (task == NULL)
> > +		return -EINVAL;
> > +	status->output_size = task->output_size;
> > +	status->active = task->active ? 1 : 0;
> > +	status->finished = task->finished ? 1 : 0;
> 
> Not sure, but access to ->active and ->finished, feels to me like
> something that may require locking.

Or better to make it a single state field?


thanks,

Takashi