Re: [PATCH 0/9] ALSA: Use *-y instead of *-objs in Makefile

[Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>]

On 5/10/24 07:15, Andy Shevchenko wrote:
> On Thu, May 09, 2024 at 08:28:32PM +0200, Takashi Iwai wrote:
> > On Thu, 09 May 2024 18:10:39 +0200,
> > Pierre-Louis Bossart wrote:
> > > On 5/8/24 04:02, Takashi Iwai wrote:
> > > > On Tue, 07 May 2024 22:53:46 +0200,
> > > > Andy Shevchenko wrote:
> > > > > On Tue, May 07, 2024 at 07:02:35PM +0300, Andy Shevchenko wrote:
> > > > > > On Tue, May 07, 2024 at 03:55:00PM +0200, Takashi Iwai wrote:
>
> > > > > > > this is a series of trivial cleanup patches for Makefile in sound/*
> > > > > > > (modulo ASoC -- which will be submitted later in a separate series).
> > > > > > >
> > > > > > > As Andy suggested in a patch review, *-objs suffix in Makefile is
> > > > > > > basically a mis-use nowadays for kernel driver modules.  They should
> > > > > > > be replaced with *-y suffix instead.  This is a result of systematic
> > > > > > > conversions, separated per directory.
> > > > > >
> > > > > > I briefly looked at this and since it's a mechanical conversion I don't see
> > > > > > any issues, so
> > > > > >
> > > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > > >
> > > > > Btw, make W=1 nowadays enables modpost checks, which complain about absence of
> > > > > MODULE_DESCRIPTION().
> > > > >
> > > > > Example:
> > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/core/snd-pcm-dmaengine.o
> > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-intel-atom.o
> > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-byt.o
> > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/intel/snd-sof-acpi-intel-bdw.o
> > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-utils.o
> > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/sof/snd-sof-acpi.o
> > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/ac97_bus.o
> > > > >
> > > > > I'm not sure what the case now for ALSA, just FYI.
> > > >
> > > > Indeed there are lots of code that miss MODULE_DESCRIPTION().
> > > ...
> > > > There are too many stuff in sound/soc/sof/* and I leave them to SOF
> > > > people (Cc'ed), while I'm going to submit the fix patches for the
> > > > rest.
> > >
> > > ok, I'll take care of it. I wasn't aware this was a requirement.
> >
> > It wasn't, but now became so :)
>
> Seems this is the result of fixing... the 2008 bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=10770

I've been slowly cleaning these tree-wide.
Will now remove sound/... from my "hit list" :)