Re: [PATCH stable-6.9.y] ASoC: Intel: sof_sdw: use generic rtd_init function for Realtek SDW DMICs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, May 21, 2024 at 10:24:51AM +0300, Peter Ujfalusi wrote:
> From: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> 
> commit bee2fe44679f1e6a5332d7f78587ccca4109919f upstream.
> 
> The only thing that the rt_xxx_rtd_init() functions do is to set
> card->components. And we can set card->components with name_prefix
> as rt712_sdca_dmic_rtd_init() does.
> And sof_sdw_rtd_init() will always select the first dai with the
> given dai->name from codec_info_list[]. Unfortunately, we have
> different codecs with the same dai name. For example, dai name of
> rt715 and rt715-sdca are both "rt715-aif2". Using a generic rtd_init
> allow sof_sdw_rtd_init() run the rtd_init() callback from a similar
> codec dai.
> 
> Fixes: 8266c73126b7 ("ASoC: Intel: sof_sdw: add common sdw dai link init")
> Reviewed-by: Chao Song <chao.song@xxxxxxxxxxxxxxx>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
> Signed-off-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> Link: https://msgid.link/r/20240326160429.13560-25-pierre-louis.bossart@xxxxxxxxxxxxxxx
> Link: https://github.com/thesofproject/linux/issues/4999 # 6.9.y stable report
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 6.9
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
> ---
> Hi,
> 
> Regression reported in 6.9 by a user:
> https://github.com/thesofproject/linux/issues/4999
> 
> The fix for the issue somehow dodged the 6.9 cycle and only landed mainline
> for 6.10, before -rc1 tag.
> 
> Our trust in machines shaken a bit, so just to make sure that this patch is
> picked for stable 6.9, I have cherry-picked it and tested on a device that
> it is working without any side-effect.

Now queued up, thanks.

greg k-h




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux