RE: [PATCH v3 2/2] ASoC: cdns: Add drivers of Cadence Multi-Channel I2S Controller

[Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx>]

> Subject: [PATCH v3 2/2] ASoC: cdns: Add drivers of Cadence Multi-Channel I2S
> Controller
> 
> Add the drivers of Cadence Multi-Channel I2S Controller.
> 
> The Cadence I2S Controller implements a function of the multi-channel (up to 8-
> channel) bus. Each stereo channel combines functions of a transmitter and a
> receiver. Each channel has independent and internal gating, clock and
> interruption control. It alos support some of these channels are used as playback
> and others can also be used as record in the same time.
> 
> The I2S-MC is used on the StarFive JH8100 SoC and add the compatible for this.
> 
> Signed-off-by: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx>
> ---
>  MAINTAINERS                      |   6 +
>  sound/soc/Kconfig                |   1 +
>  sound/soc/Makefile               |   1 +
>  sound/soc/cdns/Kconfig           |  18 +
>  sound/soc/cdns/Makefile          |   3 +
>  sound/soc/cdns/cdns-i2s-mc-pcm.c | 285 +++++++++++++
>  sound/soc/cdns/cdns-i2s-mc.c     | 704 +++++++++++++++++++++++++++++++
>  sound/soc/cdns/cdns-i2s-mc.h     | 151 +++++++
>  8 files changed, 1169 insertions(+)
>  create mode 100644 sound/soc/cdns/Kconfig  create mode 100644
> sound/soc/cdns/Makefile  create mode 100644 sound/soc/cdns/cdns-i2s-mc-
> pcm.c  create mode 100644 sound/soc/cdns/cdns-i2s-mc.c  create mode 100644
> sound/soc/cdns/cdns-i2s-mc.h
> 

Hi Mark,

Could you please help to review and give your comment about this I2S driver?
Thank you very much!

Best regards,
Xingyu Wu