Re: [PATCH 0/3] ASoC: grace time for DPCM cleanup

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi Jerome

I need your help

> > I have tested this series on an Amlogic device (vim3l)
> > This brings warnings for cases which are perfectly fine.
> > 
> > For example, one of the DPCM backends is the TDM interface. This
> > interface is capable of both playback and capture. It can be associated
> > with any i2s/TDM codec.
> > 
> > The codec may do playback and capture too, but it
> > may also do a single direction. Then usual example is the hdmi codec
> > which does playback only.
> > 
> > In this case I get:
> >  axg-sound-card sound: CPU capture is available but Codec capture is not (be.dai-link-6) Please update Codec driver
> > 
> > I don't think this is right.
> 
> Hmm..., I'm confusing
> Does it mean you want to use "playback only" on it ?
> If so, did you get below warning too ?
> 	 "both playback/capture are available, but not using playback_only flag (%s)\n",
> 
> If not, can you please fill below ?
> 
> Card
> 	dpcm_playback = (0 or 1)
> 	dpcm_capture  = (0 or 1)
> 	playback_only = (0 or 1)
> 	capture_only  = (0 or 1)
> BE.CPU
> 	playback = (available, not available)
> 	capture  = (available, not available)
> BE.Codec
> 	playback = (available, not available)
> 	capture  = (available, not available)
> Expect
> 	playback = (available, not available)
> 	capture  = (available, not available)

I need feedback from you, it is still not clear for me.
But I noticed that we want to update below. I'm happy if it can solve your
issue.

-	if (has_playback && !has_playback_both)
+	if (has_playback && !has_playback_both && !dai_link->capture_only)
		dev_warn(rtd->card->dev, ...)

-	if (has_capture && !has_capture_both)
+	if (has_capture && !has_capture_both && !dai_link->playback_only)
		dev_warn(rtd->card->dev, ...)



Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto