On Wed, May 08, 2024 at 07:00:03AM -0700, Jakub Kicinski wrote: > On Wed, 8 May 2024 10:55:05 +0800 Tao Su wrote: > > Back to commit 38c957f07038, I don't see any advantage in using LINE_MAX. > > Can we use a fixed value instead of LINE_MAX? E.g., 1024, 2048. Then we > > just need to revert commit 809216233555. > > SGTM, FWIW. The print is printing a test summary line, printing more > than 1k seems rather unreasonable. Other facilities, like TH_LOG(), > should be used for displaying longer info. Thanks, do you think 1k is enough for test_name? >
- Follow-Ups:
- Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- From: Jakub Kicinski
- Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- References:
- [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- From: Tao Su
- Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- From: Andrew Morton
- Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- From: Tao Su
- Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- From: Jakub Kicinski
- [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- Prev by Date: Re: [PATCH 00/34] ASoC: Use *-y instead of *-objs in Makefile
- Next by Date: Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- Previous by thread: Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- Next by thread: Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
- Index(es):