Re: [PATCH 1/3] ASoC: dt-bindings: samsung,midas-audio: Add GPIO-based headset jack detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 03/05/2024 20:55, Artur Weber wrote:
> Some Samsung devices that share the midas-audio driver use a GPIO-based
> approach to headset jack detection, as opposed to using the built-in
> jack detection provided by the wm8994 driver.
> 
> Add DT configuration values that allow for describing these setups.
> 
> Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx>
> ---
>  .../bindings/sound/samsung,midas-audio.yaml        | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
> index 6ec80f529d84..9f521131f2b3 100644
> --- a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
> +++ b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
> @@ -61,6 +61,36 @@ properties:
>      maxItems: 1
>      description: GPIO pin for line out selection
>  
> +  headset-detect-gpios:
> +    maxItems: 1
> +    description: GPIO for detection of headset insertion
> +
> +  headset-key-gpios:
> +    maxItems: 1
> +    description: GPIO for detection of headset key press
> +
> +  io-channels:
> +    maxItems: 1
> +    description: IO channel to read micbias voltage for headset detection
> +
> +  io-channel-names:
> +    const: headset-detect
> +
> +  headset-4pole-threshold-microvolt:

You need vendor prefix for this and next property.

> +    minItems: 2
> +    maxItems: 2
> +    description: |

Do not need '|' unless you need to preserve formatting.



Best regards,
Krzysztof





[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux