Re: [PATCH 0/4] ALSA: pcm: obsolete sync member in runtime structure

[Jaroslav Kysela <perex@xxxxxxxx>]

On 01. 05. 24 13:34, Takashi Sakamoto wrote:
> Hi,
>
> Seven years ago, in Linux kernel version 4.13, the data of
> snd_pcm_sync_id union is not exposed to user space anymore, by a commit
> e11f0f90a626 ("ALSA: pcm: remove SNDRV_PCM_IOCTL1_INFO internal command").
> > From then, we have received no issued related to it. It means that the
> data is neither used by any practical applications nor drivers, thus it
> can be removed.
>
> This series of change is to obsolete the usage of the union data
> in PCM core function. The kernel API, snd_pcm_set_sync(), is removed.
> and the 'sync' member of snd_pcm_runtime structure is removed. Finally,
> some notes are added to UAPI header.
>
> The removal of sync field has a side effect for emu10k driver, since p16v
> chip code sets the data by hand. Its removal requires any deliberate
> discussion, but the calm in seven years would satisfy the condition of
> it.
>
>
> The patch comment sent by Jaroslav[1] refers to the reinvention of the
> union data, but as the part of hardware configuration step. If it
> proceeds, the UAPI note would be modified simply.

Strong NAK until we have another API replacement.

					Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.