Re: [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC

[WTLI <wtli@xxxxxxxxxxx>]

Rob Herring 於 4/12/2024 11:52 PM 寫道:
> CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content.
>
>
> On Fri, Apr 12, 2024 at 06:35:52PM +0800, Seven Lee wrote:
> > Change the original fixed delay to the assignment from the property. It
> > will make it more flexible to different platforms to avoid pop noise at
> > the beginning of recording.
> >
> > Signed-off-by: Seven Lee <wtli@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> > index 054b53954ac3..a726c5a9b067 100644
> > --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> > +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> > @@ -103,6 +103,13 @@ properties:
> >           just limited to the left adc for design demand.
> >       type: boolean
> >
> > +  nuvoton,adc-delay-ms:
> > +    description: Delay (in ms) to make input path stable and avoid pop noise.
> > +        The default value is 125 and range between 125 to 500 ms.
> No need to state constraints in prose.

okay, I will fix it.

> > +    minimum: 125
> > +    maximum: 500
> > +    default: 125
> > +
> >     '#sound-dai-cells':
> >       const: 0
> >
> > @@ -136,6 +143,7 @@ examples:
> >               nuvoton,jack-eject-debounce = <0>;
> >               nuvoton,dmic-clk-threshold = <3072000>;
> >               nuvoton,dmic-slew-rate = <0>;
> > +            nuvoton,nuvoton,adc-delay-ms = <125>;
> >               #sound-dai-cells = <0>;
> >           };
> >       };
> > --
> > 2.25.1
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.