[PATCH 00/17] ASoC: SOF: ipc4/Intel: Fix delay reporting (for 6.9 / 6.8)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi,

The current version of delay reporting code can report incorrect
values when paired with a firmware which enables this feature.

Unfortunately there are several smaller issues that needed to be addressed
to correct the behavior:

Wrong information was used for the host side of counter
For MTL/LNL used incorrect (in a sense that it was verified only on MTL)
link side counter function.
The link side counter needs compensation logic if pause/resume is used.
The offset values were not refreshed from firmware.
Finally, not strictly connected, but the ALSA buffer size needs to be
constrained to avoid constant xrun from media players (like mpv)

The series applies cleanly for 6.9 and 6.8.y stable, but older stable
would need manual backport, but it is questionable if it is needed as
MTL/LNL is missing features.

Mark, can you pick these patches for the 6.9 cycle as fixes?

Regards,
Peter
---
Peter Ujfalusi (17):
  ASoC: SOF: Add dsp_max_burst_size_in_ms member to snd_sof_pcm_stream
  ASoC: SOF: ipc4-topology: Save the DMA maximum burst size for PCMs
  ASoC: SOF: Intel: hda-pcm: Use dsp_max_burst_size_in_ms to place
    constraint
  ASoC: SOF: Intel: hda: Implement get_stream_position (Linear Link
    Position)
  ASoC: SOF: Intel: mtl/lnl: Use the generic get_stream_position
    callback
  ASoC: SOF: Introduce a new callback pair to be used for PCM delay
    reporting
  ASoC: SOF: Intel: Set the dai/host get frame/byte counter callbacks
  ASoC: SOF: ipc4-pcm: Use the snd_sof_pcm_get_dai_frame_counter() for
    pcm_delay
  ASoC: SOF: Intel: hda-common-ops: Do not set the get_stream_position
    callback
  ASoC: SOF: Remove the get_stream_position callback
  ASoC: SOF: ipc4-pcm: Move struct sof_ipc4_timestamp_info definition
    locally
  ASoC: SOF: ipc4-pcm: Combine the SOF_IPC4_PIPE_PAUSED cases in
    pcm_trigger
  ASoC: SOF: ipc4-pcm: Invalidate the stream_start_offset in PAUSED
    state
  ASoC: SOF: sof-pcm: Add pointer callback to sof_ipc_pcm_ops
  ASoC: SOF: ipc4-pcm: Correct the delay calculation
  ALSA: hda: Add pplcllpl/u members to hdac_ext_stream
  ASoC: SOF: Intel: hda: Compensate LLP in case it is not reset

 include/sound/hdaudio_ext.h          |   3 +
 sound/soc/sof/intel/hda-common-ops.c |   3 +
 sound/soc/sof/intel/hda-dai-ops.c    |  11 ++
 sound/soc/sof/intel/hda-pcm.c        |  29 ++++
 sound/soc/sof/intel/hda-stream.c     |  70 ++++++++++
 sound/soc/sof/intel/hda.h            |   6 +
 sound/soc/sof/intel/lnl.c            |   2 -
 sound/soc/sof/intel/mtl.c            |  14 --
 sound/soc/sof/intel/mtl.h            |  10 --
 sound/soc/sof/ipc4-pcm.c             | 191 ++++++++++++++++++++++-----
 sound/soc/sof/ipc4-priv.h            |  14 --
 sound/soc/sof/ipc4-topology.c        |  22 ++-
 sound/soc/sof/ops.h                  |  24 +++-
 sound/soc/sof/pcm.c                  |   8 ++
 sound/soc/sof/sof-audio.h            |   9 +-
 sound/soc/sof/sof-priv.h             |  24 +++-
 16 files changed, 351 insertions(+), 89 deletions(-)

-- 
2.44.0





[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux