Re: [PATCH v9 2/5] dt-bindings: input: cirrus,cs40l50: Add initial DT binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi Krzysztof,

On Mon, Mar 11, 2024 at 07:31:36AM +0100, Krzysztof Kozlowski wrote:
> On 10/03/2024 20:29, Jeff LaBundy wrote:
> > 
> >> +  - vio-supply
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> +  - |
> >> +    #include <dt-bindings/gpio/gpio.h>
> >> +    #include <dt-bindings/interrupt-controller/irq.h>
> >> +
> >> +    i2c {
> >> +      #address-cells = <1>;
> >> +      #size-cells = <0>;
> > 
> > Nit: most device trees tend to use 8-column indentation as with kernel code.
> 
> If you meant DTS, then kernel coding style applies, which does not use
> spaces. But this is a binding, so please use indentation as defined by
> writing-schema: 2 or 4 spaces.

Good to know; I'll follow this definition moving forward.

> 
> 
> Best regards,
> Krzysztof
> 

Kind regards,
Jeff LaBundy




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux