Re: [PATCH V3] ALSA: hda/realtek - ALC236 fix volume mute & mic mute LED on some HP models

[Takashi Iwai <tiwai@xxxxxxx>]

On Tue, 12 Mar 2024 02:18:28 +0100,
fætalize wrote:
> 
> Some HP laptops have received revisions that altered their board IDs
> and therefore the current patches/quirks do not apply to them.
> Specifically, for my Probook 440 G8, I have a board ID of 8a74.
> It is necessary to add a line for that specific model.
> 
> Signed-off-by: Valentine Altair faetalize@xxxxxxxxx
> ---
> V2 -> V3: regenerated diff using git.
> V1 -> V2: No changes.

Almost good, but just a few things:

- The alc269_fixup_tblp[] is sorted in PCI SSID order;
  put the entry at the right position
- Signed-off-by line should be in the format "Real Name <real@xxx>"
- The address in the From line should match with Signed-off-by line;
  if the mail set up is difficult to change, you can put "From: ...."
  line at the beginning of the patch itself, too.

Could you resubmit with those corrections?


thanks,

Takashi


> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index a1facdb..f04c3c1 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9890,6 +9890,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> +	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC q", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),