On Mon, 04 Mar 2024 21:56:29 +0100,
Heiner Kallweit wrote:
>
> If a simple trigger is assigned to a LED, then the LED may be off until
> the next led_trigger_event() call. This may be an issue for simple
> triggers with rare led_trigger_event() calls, e.g. power supply
> charging indicators (drivers/power/supply/power_supply_leds.c).
> Therefore persist the brightness value of the last led_trigger_event()
> call and use this value if the trigger is assigned to a LED.
> This change allows to use simple triggers in more cases.
> As a first use case simplify handling of the mute audio trigger.
>
> This series touches few subsystems. I'd propose to handle it via
> the LED subsystem.
>
> v2:
> - Split out patch 3 from series and apply it separately via Input tree
> - Improve bisectability and ensure that audio mute trigger can't be
> built twice between patches 2 and 4.
>
> Heiner Kallweit (3):
> leds: trigger: Store brightness set by led_trigger_event()
> ALSA: control-led: Integrate mute led trigger
> leds: trigger: audio: Remove this trigger
Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>
thanks,
Takashi
[Index of Archives]
[Pulseaudio]
[Linux Audio Users]
[ALSA Devel]
[Fedora Desktop]
[Fedora SELinux]
[Big List of Linux Books]
[Yosemite News]
[KDE Users]