Re: [PATCH 1/5] ASoC: Intel: Disable route checks for Skylake boards

[Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>]

On 3/4/24 13:05, Cezary Rojewski wrote:
> Topology files that are propagated to the world and utilized by the
> skylake-driver carry shortcomings in their SectionGraphs.
> 
> Since commit daa480bde6b3 ("ASoC: soc-core: tidyup for
> snd_soc_dapm_add_routes()") route checks are no longer permissive. Probe
> failures for Intel boards have been partially addressed by commit
> a22ae72b86a4 ("ASoC: soc-core: disable route checks for legacy devices")
> and its follow up but only skl_nau88l25_ssm4567.c is patched. Fix the
> problem for the rest of the boards.
> 
> Link: https://lore.kernel.org/all/20200309192744.18380-1-pierre-louis.bossart@xxxxxxxxxxxxxxx/
> Fixes: daa480bde6b3 ("ASoC: soc-core: tidyup for snd_soc_dapm_add_routes()")
> Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
> ---
>  sound/soc/intel/boards/bxt_da7219_max98357a.c       | 1 +
>  sound/soc/intel/boards/bxt_rt298.c                  | 1 +
>  sound/soc/intel/boards/glk_rt5682_max98357a.c       | 1 +
>  sound/soc/intel/boards/kbl_da7219_max98357a.c       | 1 +
>  sound/soc/intel/boards/kbl_da7219_max98927.c        | 4 ++++
>  sound/soc/intel/boards/kbl_rt5660.c                 | 1 +
>  sound/soc/intel/boards/kbl_rt5663_max98927.c        | 2 ++
>  sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 1 +
>  sound/soc/intel/boards/skl_hda_dsp_generic.c        | 1 +

This HDAudio machine driver is shared with the SOF-based solutions and I
see no reason to change the route checking...

I don't agree with this change. Why can't you fix the broken topologies
instead, if indeed they 'carry shortcomings'?

Same for glk, this an SOF-based solution.

>  sound/soc/intel/boards/skl_nau88l25_max98357a.c     | 1 +
>  sound/soc/intel/boards/skl_rt286.c                  | 1 +
>  11 files changed, 15 insertions(+)