Re: [PATCH v2 1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains requirement

[Conor Dooley <conor@xxxxxxxxxx>]

On Tue, Feb 27, 2024 at 03:54:09PM -0500, Frank Li wrote:
> Add power-domains property for asrc and spdif.

Is this valid for all compatibles documented in these bindings?
Also, your $subject says "requirement", but you do not mark these as
required. Why not?

Cheers,
Conor.

> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml | 3 +++
>  Documentation/devicetree/bindings/sound/fsl,spdif.yaml    | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> index bfef2fcb75b14..98616507e3c10 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> @@ -74,6 +74,9 @@ properties:
>        - const: asrck_f
>        - const: spba
>  
> +  power-domains:
> +    maxItems: 1
> +
>    fsl,asrc-rate:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: The mutual sample rate used by DPCM Back Ends
> diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> index 1d64e8337aa4b..82430f1d5e5a2 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> @@ -86,6 +86,9 @@ properties:
>        registers. Set this flag for HCDs with big endian descriptors and big
>        endian registers.
>  
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> 
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature