Re: [PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

[Cezary Rojewski <cezary.rojewski@xxxxxxxxx>]

On 2024-02-22 6:24 PM, Ville Syrjälä wrote:
> On Thu, Feb 22, 2024 at 06:06:11PM +0100, Cezary Rojewski wrote:
> > Commit 78f613ba1efb ("drm/i915: finish removal of CNL") and its friends
> > removed support for i915 for all CNL-based platforms. HDAudio library,
> > however, still treats such platforms as valid candidates for i915
> > binding. Update query mechanism to reflect changes made in drm tree.
> >
> > At the same time, i915 support for LKF-based platforms has not been
> > provided so remove them from valid binding candidates.

...

> > @@ -127,15 +128,26 @@ static int i915_component_master_match(struct device *dev, int subcomponent,
> >   /* check whether Intel graphics is present and reachable */
> >   static int i915_gfx_present(struct pci_dev *hdac_pci)
> >   {
> > +	/* List of known platforms with no i915 support. */
> > +	static struct pci_device_id denylist[] = {
> > +		INTEL_CNL_IDS(NULL),
> > +		INTEL_LKF_IDS(NULL),
> > +		{ 0 }
> > +	};
>
> I thought these don't actually exist in the wild?

To my knowledge the opposite is true - while LKFs were shipped in 
limited number, they still were. I did ask few weeks ago my friends from 
Windows side about the support and they're still running full-scopes on 
HDMI endpoints on LKF platforms in their CIs. It seems the drm support 
is there though. Once you re-boot to linux we get -19 during probe().

In regard to CNL, the commit removing CNL-support left the IDs intact 
what's very handy to us - we have a lot of spare CNL boards for our 
validation purposes - CNL-based AudioDSP spans multiple platforms, e.g.: 
CNL/CFL/WHL/CML. The number of newer boards is lower, unfortunately.


Kind regards,
Czarek