On Wed, Feb 07, 2024 at 04:16:02PM +0000, Richard Fitzgerald wrote: > + if (!cs35l56->asp1_mixer_widgets_initialized) { > + ret = cs35l56_sync_asp1_mixer_widgets_with_firmware(cs35l56); > + if (ret) > + return ret; > + } Might it make sense to factor the check for init into the function since it looks like all the callers do it and I'd expect that'd be the case for any new ones?
Attachment:
signature.asc
Description: PGP signature
- References:
- [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register initialization
- From: Richard Fitzgerald
- [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register initialization
- Prev by Date: [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register initialization
- Next by Date: Re: [PATCH v2] ALSA: hda/realtek: cs35l41: Fix internal speaker support for ASUS UM3402 with missing DSD
- Previous by thread: [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register initialization
- Index(es):