Re: [PATCH] Apply headset jack fixup for alc287 thinkpads

[Takashi Iwai <tiwai@xxxxxxx>]

On Tue, 30 Jan 2024 20:25:36 +0100,
José Relvas wrote:
> 
> Thinkpads have a fixup for alc285 which enables headset media buttons, but not for alc287.
> This patch removes the chain to the X1 gen 7 fixup in the alc285 headset fixup, making it applicable for models without bass speakers.
> It then chains said headset fixup with every alc287 thinkpad fixup, making headset media buttons work for these laptops.
> 
> Signed-off-by: José Relvas <josemonsantorelvas@xxxxxxxxx>

Thanks for the patch.  But the changes look too intrusive.  We don't
want to change the behavior of the existing quirk entries
unnecessarily.  Your change will break if anyone explicitly uses a
specific model option, for example.
So, please rather create a new entry for handling the headset jack and
use it (maybe better with some comments).

Also the patch isn't cleanly applicable.  Your MUA broke tabs and
spaces.  Please fix the setup, or use git-send-email.


thanks,

Takashi