Re: [PATCH] ALSA: hda: Increase default bdl_pos_adj for Apollo Lake

[Rui Salvaterra <rsalvaterra@xxxxxxxxx>]

Hi, Amadeusz,

On Mon, 22 Jan 2024 at 11:05, Amadeusz Sławiński
<amadeuszx.slawinski@xxxxxxxxxxxxxxx> wrote:
>

[snipped]

> And seems like I've missed some IDs, when doing PCI IDs conversion.
> Anyway, can you use PCI_DEVICE_ID_INTEL_HDA_APL instead of 0x5a98 as it
> is self describing (no need for comment)?

Oh, of course! I would have done it if I knew we had those constants defined. :)

> And if you want more patches in kernel - convert first 0x0f04 & 0x2284
> to PCI_DEVICE_ID_INTEL_HDA_BYT & PCI_DEVICE_ID_INTEL_HDA_BSW and then do
> the above change ;)

Killing magic numbers is always a worthwhile goal. Expect a two-patch
series soon, then. ;)

Cheers,
Rui