Re: [PATCH] ALSA: hda/relatek: Enable Mute LED on HP Laptop 15s-fq2xxx

[Takashi Iwai <tiwai@xxxxxxx>]

On Sat, 13 Jan 2024 03:37:33 +0100,
Çağhan Demir wrote:
> 
> This HP Laptop uses ALC236 codec with COEF 0x07 idx 1 controlling
> the mute LED. This patch enables the already existing quirk for
> this device.
> 
> Signed-off-by: Çağhan Demir <caghandemir@xxxxxxxxxxxx>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b68c94757..124bee526 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9876,6 +9876,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
>  	SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
>  	SND_PCI_QUIRK(0x103c, 0x887a, "HP Laptop 15s-eq2xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> +	SND_PCI_QUIRK(0x103c, 0x87FE, "HP Laptop 15s-fq2xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),

The entry is sorted in PCI SSID order.
Could you put it at the right position?
Also, the lower alphabets are used for hex numbers in general.


thanks,

Takashi