Re: [PATCH v2 1/4] reset: gpio: Add GPIO-based reset controller

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 08/01/2024 13:21, Philipp Zabel wrote:
> On Fr, 2024-01-05 at 16:59 +0100, Krzysztof Kozlowski wrote:
>> Add a simple driver to control GPIO-based resets using the reset
>> controller API for the cases when the GPIOs are shared and reset should
>> be coordinated.  The driver is expected to be used by reset core
>> framework for ad-hoc reset controllers.
> 
> I don't know how evil it is to set a parent-less platform device's
> of_node to another device's node, but I like the simplicity of a
> single-GPIO reset controller driver more that I had expected.
> 
> [...]
>> diff --git a/drivers/reset/reset-gpio.c b/drivers/reset/reset-gpio.c
>> new file mode 100644
>> index 000000000000..cf0a867cbc5f
>> --- /dev/null
>> +++ b/drivers/reset/reset-gpio.c
>> @@ -0,0 +1,121 @@
> [...]
>> +static void reset_gpio_of_args_put(void *data)
> 
> This should probably be called reset_gpio_of_node_put().

Ack

Best regards,
Krzysztof