Re: Oops in hdac_hda_dev_probe (6.7-rc7)

[Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>]

Am Fri, Dec 29, 2023 at 06:11:43PM +0100 schrieb Takashi Iwai:
> On Fri, 29 Dec 2023 16:24:18 +0100,
> Dominik Brodowski wrote:
> > 
> > Hi Takashi,
> > 
> > many thanks for your response. Your patch helps half-way: the oops goes
> > away, but so does the sound... With your patch, the decisive lines in dmesg
> > are:
> > 
> > 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
> > 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
> > 	sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
> > 	sof_sdw sof_sdw: snd_soc_register_card failed -517
> > 	sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
> > 	sof_sdw sof_sdw: snd_soc_register_card failed -517
> > 	platform sof_sdw: deferred probe pending
> > 
> > With a revert of the a0575b4add21, it is:
> > 
> > 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
> > 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
> > 	sof-audio-pci-intel-tgl 0000:00:1f.3: Topology: ABI 3:22:1 Kernel ABI 3:23:0
> > 	sof_sdw sof_sdw: ASoC: Parent card not yet available, widget card binding deferred
> > 	sof_sdw sof_sdw: hda_dsp_hdmi_build_controls: no PCM in topology for HDMI converter 3
> > 	input: sof-soundwire HDMI/DP,pcm=5 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input14
> > 	input: sof-soundwire HDMI/DP,pcm=6 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input15
> > 	input: sof-soundwire HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input16
> > 
> > Maybe this helps a bit further?
> 
> Thanks for quick testing.
> It shows at least that my guess wasn't wrong.
> 
> The problem could be the initialization order in the caller side.
> Can the patch below work instead?

Unfortunately, no:

sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
sof_sdw sof_sdw: snd_soc_register_card failed -517
sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
sof_sdw sof_sdw: snd_soc_register_card failed -517
platform sof_sdw: deferred probe pending

Thanks,	
	Dominik