Re: [PATCH] enable SND_PCI_QUIRK for hp pavilion 14-ec1xxx series

[Takashi Iwai <tiwai@xxxxxxx>]

On Fri, 29 Dec 2023 15:55:33 +0100,
Aabish Malik wrote:
> 
> The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec.
> The mute led can be enabled using the already existing
> ALC287_FIXUP_HP_GPIO_LED quirk.
> Tested on an HP Pavilion ec1003AU
> 
> Signed-off-by: Aabish Malik <aabishmalik3337@xxxxxxxxx>

Almost good, but...  Please test your patch by yourself before
submission.  It's missing a comma at the new line, hence it gives the
compilation error.

Also, the subject line could be improved.  We take usually "ALSA:"
prefix, and also for this kind of stuff, "hda/realtek:" is used in
addition, so the subject should be "ALSA: hda/realtek: enable
SND_PCI_QUIRK for hp pavilion 14-ec1xxx series".

And, when you resubmit a revised patch, put the revision number like
"[PATCH v2]".


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index c3a756528..961555dfc 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>  	SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> +	SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx" ALC287_FIXUP_HP_GPIO_LED)
>  	SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>  	SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> -- 
> 2.43.0
>