Re: [PATCH v3 4/5] ASoC: tas2781: Add tas2563 into driver

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Dec 25, 2023 at 01:39:30PM +0800, Shenghao Ding wrote:
> Move tas2563 from tas2562 driver to tas2781 driver, because tas2563 only
> work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode
> for tas2563, it has been moved to tas2781 driver. As to the hardware part,
> such as register setting and DSP firmware, all these are stored in the
> binary firmware. What tas2781 drivder dooes is to parse the firmware and
> download them to the tas2781 or tas2563, then power on tas2781 or tas2563.
> So, tas2781 driver can be resued as tas2563 driver. Only attention will be
> paid to downloading corresponding firmware.

> -// The TAS2781 driver implements a flexible and configurable
> +// The TAS2781/TAS2563 driver implements a flexible and configurable

> -// TAS2781 chips.
> +// TAS2781/TAS2563 chips.

>  static const struct i2c_device_id tasdevice_id[] = {
>  	{ "tas2781", TAS2781 },
> +	{ "tas2563", TAS2563 },
>  	{}
>  };

>  static const struct of_device_id tasdevice_of_match[] = {
>  	{ .compatible = "ti,tas2781" },
> +	{ .compatible = "ti,tas2563" },
>  	{},
>  };

In all cases make the lists ordered by a chip model.

-- 
With Best Regards,
Andy Shevchenko