Re: ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Wed, 13 Dec 2023 20:36:09 +0100,
Clément Villeret wrote:
> 
> 
> Asus ROG Flowx13 (GV302XA) seems require same patch as others asus products
> 
> Signed-off-by: Clément Villeret <clement.villeret@xxxxxxxxx>

Now better, but...

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> 
> index 0377912e9264..eb9f617b6273 100644
> 
> --- a/sound/pci/hda/patch_realtek.c
> 
> +++ b/sound/pci/hda/patch_realtek.c
> 
> @@ -9953,6 +9953,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> 
>                       SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", ALC285_FIXUP_ASUS_HEADSET_MIC),
> 
>                       SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
(snip)

The lines above are weirdly formatted with extra line feeds.
Try the following before resubmission:
- Send the patch to yourself, save the mail content
- Apply the mail content via "git am" command
- If this works, it's a correct patch; then submit to the public ML

Also, note that you'd need to put a blank line before Signed-off-by
line.


thanks,

Takashi




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux