Re: [Linux-Kernel][PATCH] Add quirk ASUS GV302XA

[Geraldo Nascimento <geraldogabriel@xxxxxxxxx>]

On Sun, Dec 10, 2023 at 09:09:41PM +0100, Clément Villeret wrote:
>

Hi Clément,

you need a commit message here describing what changes are introduced by
the commit you are proposing, and why they are needed. In your case it's
a very simple change and a simple commit message would do, you may want
to check patchwork if you're in doubt.

Also, when you address the commit message concern and are ready to send
v2, remember to include Takashi Iwai (co-maintainer of ALSA together
with Jaroslav Kysela) in the Cc:

Thanks,
Geraldo Nascimento

> ---
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f9ddacfd920e..acbb88d777a2 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9954,6 +9954,7 @@ static const struct snd_pci_quirk 
> alc269_fixup_tbl[] = {
>       SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", 
> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
>       SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", 
> ALC285_FIXUP_ASUS_HEADSET_MIC),
>       SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", 
> ALC294_FIXUP_ASUS_DUAL_SPK),
> +    SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA", 
> ALC287_FIXUP_CS35L41_I2C_2),
>       SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZV", 
> ALC285_FIXUP_ASUS_HEADSET_MIC),
>       SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", 
> ALC287_FIXUP_CS35L41_I2C_2),
>       SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
> -- 
> 2.43.0
> 
> 
> 
> 
> Hi, it's my very first time trying to contribute to linux kernel. I hope 
> the diff format is ok.
> 
> my fork : https://github.com/nectogale/linux-quirk-ASUS-GV302XA/tree/master
> 
> Have a nice day.
> 
>