Re: [PATCH 2/5] ASoC: wm1250-ev1: Convert to GPIO descriptors

[Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>]

On Fri, Dec 08, 2023 at 11:09:26AM +0100, Linus Walleij wrote:
> This converts the WM1250-EV1 codec to use GPIO descriptors.
> It turns out that the platform data was only used to pass some
> global GPIO numbers from a board file, so we get rid of this
> and also switch over the single in-tree user in the S3C
> Cragganmore module for S3C 6410.
> 
> The driver obtains two GPIO lines named OSR and master and just
> pull them low, we leave this behaviour as it was.
> 
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> +	.table = {
> +		GPIO_LOOKUP("GPION", 12, "clk-ena", GPIO_ACTIVE_HIGH),
> +		GPIO_LOOKUP("GPIOL", 12, "clk-sel0", GPIO_ACTIVE_HIGH),
> +		GPIO_LOOKUP("GPIOL", 13, "clk-sel1", GPIO_ACTIVE_HIGH),
> +		GPIO_LOOKUP("GPIOL", 14, "osr", GPIO_ACTIVE_HIGH),
> +		GPIO_LOOKUP("GPIOL", 8, "master", GPIO_ACTIVE_HIGH),
> +		{ },

For my curiousity, what is the significance of GPION vs GPIOL here?

But looks fine to me:

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles