On 28/11/2023 11:39, Takashi Iwai wrote: > Hm... I still find it's a bad move to use an exported symbol from > another codec driver. The other option is to check for 0x4 (or address 2), but I'm not sure if this is Intel only or universally true for HDMI codecs. > And, I wonder what if you have a system that has only one HDMI codec > without analog one? Would it still work with your change? Yes, it works with only HDMI codec (for example on SoundWire laptops) or with UP2 board which only have HDMI audio support by default. It also works if we disable HDMI and only have analog codec. -- Péter
- Follow-Ups:
- References:
- [PATCH 0/2] ALSA/ASoC: hdmi/hdac_hda: Conditionally register dais
- From: Peter Ujfalusi
- [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Peter Ujfalusi
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Takashi Iwai
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Péter Ujfalusi
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Takashi Iwai
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Péter Ujfalusi
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Takashi Iwai
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Péter Ujfalusi
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Takashi Iwai
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Péter Ujfalusi
- Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- From: Takashi Iwai
- [PATCH 0/2] ALSA/ASoC: hdmi/hdac_hda: Conditionally register dais
- Prev by Date: Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- Next by Date: Re: [PATCH] soundwire: intel_ace2x: fix AC timing setting for ACE2.x
- Previous by thread: Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- Next by thread: Re: [PATCH 1/2] ALSA: hda/hdmi: Add helper function to check if a device is HDMI codec
- Index(es):