Re: [PATCH v4 04/16] ALSA: hda: Upgrade stream-format infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 16. 11. 23 12:22, Cezary Rojewski wrote:
Introduce a set of functions that ultimately facilite SDxFMT-related
calculations in atomic manner:

First, introduce snd_pcm_subformat_width() and snd_pcm_hw_params_bps()
helpers that separate the base functionality from the HDAudio-specific
one.

I think, snd_pcm_subformat_width() should be implemented only as static helper for now. There are no users and only snd_pcm_hw_params_bps() makes sense for callers (format & subformat must be passed together).

Also note that _bps is mostly used for bits-per-second in the computer world, so maybe _bpsam may be used here to pay more attention by readers, but it's just my optional proposal. Maybe my head has some "fixed wiring" for this :)

				Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux