Re: [PATCH v2 3/3] ASoC: mediatek: mt8188-mt6359: Limit RT5682s to only supports dual channels

[Trevor Wu (吳文良) <Trevor.Wu@xxxxxxxxxxxx>]

On Wed, 2023-11-08 at 09:26 +0800, Rui Zhou wrote:
>  Limit RT5682s to only support dual channels, not four channels.

Hi Rui,

The title is still confusing, maybe update the title based on Angelo's
suggestion in v1[1]?
In addition, please modify the commit description to mention support
for stereo MAX98390 specifically for the mt8188-rt5682s board. Now, it
reads like you are adding the dual RT5682s support.

[1]https://patchwork.kernel.org/comment/25584066/

Thanks,
Trevor

> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
> Signed-off-by: Rui Zhou <zhourui@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> index e994faa3556b..917640939621 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> @@ -1549,7 +1549,7 @@ static struct mt8188_card_data
> mt8188_nau8825_card = {
>  
>  static struct mt8188_card_data mt8188_rt5682s_card = {
>  	.name = "mt8188_rt5682s",
> -	.quirk = RT5682S_HS_PRESENT,
> +	.quirk = RT5682S_HS_PRESENT | MAX98390_TWO_AMP,
>  };
>  
>  static struct mt8188_card_data mt8188_es8326_card = {
> -- 
> 2.25.1
>