Re: Sound not working after commit bbf7d3b1c4f40eb02dd1dffb500ba00b0bff0303 on Amlogic A311D device

[Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>]

On 7/9/22 06:19, Alex Natalsson wrote:
>>> +       if (!fe_substream) {
>>> +               dev_err(fe->dev, "%s: fe_substream not initialized\n",
>>> __func__);
>>> +               return -EINVAL;
>>> +       }
>>> +       if (!be_substream) {
>>> +               dev_err(be->dev, "%s: be_substream not initialized\n",
>>> __func__);
>>> +               return -EINVAL;
>>> +       }
>>> +
> 
> Will be this in upstream or needing bugzilla reporting message?
I created a patch based on this, see
https://github.com/thesofproject/linux/pull/3735

I am not sure however if this is the 'right' fix. There was a comment
from Peter Ujfalusi that a BE substream may be initialized later, but if
that's the case then the atomicity check that was introduced is done in
the wrong location.

Takashi, we could use your guidance here.
Thanks
-Pierre